Add :status field with color as a default #171
Comments
|
You can see how the morgan.format('dev', function developmentFormatLine (tokens, req, res) {
// get the status code if response written
var status = headersSent(res)
? res.statusCode
: undefined
// get status color
var color = status >= 500 ? 31 // red
: status >= 400 ? 33 // yellow
: status >= 300 ? 36 // cyan
: status >= 200 ? 32 // green
: 0 // no color
// get colored function
var fn = developmentFormatLine[color]
if (!fn) {
// compile
fn = developmentFormatLine[color] = compile('\x1b[0m:method :url \x1b[' +
color + 'm:status \x1b[0m:response-time ms - :res[content-length]\x1b[0m')
}
return fn(tokens, req, res)
})All that is needed is to get the status code and decide a color accordingly. |
Coloring status makes sense for whatever format user wants, not just the internal `dev` one. So using `:status[color]` gives that ability. As for collaterally removed memoization for `dev` format, well, wouln't it be better to memoize all formats that go through `compile`, not just the `dev` one? If that's the case, I'll do that separately. resolves expressjs#171
Coloring status makes sense for whatever format user wants, not just the internal `dev` one. So using `:status-colored` gives that ability. As for collaterally removed memoization for `dev` format, well, wouln't it be better to memoize all formats that go through `compile`, not just the `dev` one? If that's the case, I'll do that separately. resolves expressjs#171
Coloring status makes sense for whatever format user wants, not just the internal `dev` one. So using `:status-colored` gives that ability. Had to edit tests because, in master, status coloring is being disabled after a space following status specifically in dev format. Now coloring is disabled right after status text. As for collaterally removed memoization for `dev` format, well, wouln't it be better to memoize all formats that go through `compile`, not just the `dev` one? If that's the case, I'll do that separately. resolves expressjs#171
|
Yea, you can always make your own format that replicates the colors or if you would like you can always make a pull request to add it here 👍 |
|
@dougwilson Got a start on it, but struggling with failing unit tests on colored string assertions. Could use help if you've got time #175 |
|
Hi @toymachiner62 I guess I misunderstood your request. I was under the assumption you were going to make a new token called |
|
Well i was originally going to create a :colored-status, but then thought ah why not just make it the default. Didn't know the formats had to be color-less |
|
@dougwilson what about #174 with a new token? |
Coloring status makes sense for whatever format user wants, not just the internal `dev` one. So using `:status-colored` gives that ability. Memoization for `dev` format is collaterally removed since now `dev` format is just a string and coloring is compiled as the `status-colored` token. resolves expressjs#171
Coloring status makes sense for whatever format user wants, not just the internal `dev` one. So using `:status-colored` gives that ability. Memoization for `dev` format is collaterally removed since now `dev` format is just a string and coloring is compiled as the `status-colored` token. resolves expressjs#171
Coloring status makes sense for whatever format user wants, not just the internal `dev` one. So using `:status-colored` gives that ability. Memoization for `dev` format is collaterally removed since now `dev` format is just a string and coloring is compiled as the `status-colored` token. resolves expressjs#171
I love the
devconfig, only I want it to have a timestamp as well.I know that if i copy the dev config manually, I can simply add
:date[iso], but then I lose the awesome colors of the response codes.Can you either add another default format which is the
devconfig with a timestamp or can you simply make a:statusfield that by default has color? e.g.:colored-statusThe text was updated successfully, but these errors were encountered: