Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeClimate issue: Function Service has 33 lines of code. #6

Open
AnasBoulmane opened this issue Oct 21, 2019 · 0 comments
Open

codeClimate issue: Function Service has 33 lines of code. #6

AnasBoulmane opened this issue Oct 21, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@AnasBoulmane
Copy link
Member

Function Service has 33 lines of code (exceeds 25 allowed). Consider refactoring. OPEN

export function Service<T, K extends keyof T> (
  optionsOrServiceName?: ServiceOptions<T, K> | Token<any> | string | any[] | (() => any),
  maybeFactory?: (...args: any[]) => any,
): any {
  if (arguments.length === 2 || optionsOrServiceName instanceof Function) {

Severity: Minor
Found in: src/decorators/Service.ts - About 1 hr to fix

@AnasBoulmane AnasBoulmane added the enhancement New feature or request label Oct 21, 2019
@AnasBoulmane AnasBoulmane moved this from To do to In progress in express-ts/container Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
express-ts/container
  
In progress
Development

No branches or pull requests

1 participant