Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS conflicts with Sphinx-Tabs #51

Open
Daltz333 opened this issue Oct 23, 2020 · 4 comments
Open

CSS conflicts with Sphinx-Tabs #51

Daltz333 opened this issue Oct 23, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Daltz333
Copy link

Daltz333 commented Oct 23, 2020

Describe the bug

The extension seems to expand the maximum width of sphinx-tabs to the full width of the page.

image

See https://frc-docs--901.org.readthedocs.build/en/901/docs/software/advanced-controls/filters/median-filter.html#using-a-medianfilter

To Reproduce

Offending PR: wpilibsuite/frc-docs#901

Install Sphinx-Tabs and Sphinx-Panels with Sphinx 3.1.2 and Python 3

Expected behavior

The original sphinx-tabs to retain it's style. Ideally we'd like to use both sphinx-tabs and sphinx-panels (we prefer the design of sphinx-tabs over sphinx-panels .. tabbed:: as well as we make extensive use of group-tabs)

https://frc-docs--901.org.readthedocs.build/en/901/
image

Environment

  • Python Version [Python 3.6.2)
  • Operating System: Ubuntu 18.04

Additional context

https://github.com/wpilibsuite/frc-docs

@Daltz333 Daltz333 added the bug Something isn't working label Oct 23, 2020
@welcome
Copy link

welcome bot commented Oct 23, 2020

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

@Daltz333
Copy link
Author

Daltz333 commented Oct 23, 2020

Additionally research shows that bootstrap is missing up with some margins and padding. I've managed to get it looking somewhat right by doing the below modifications:

Removing all of the following style fixes it
image

Which gives the original output looking like the following
image

@chrisjsewell
Copy link
Member

Hey @Daltz333 yep see executablebooks/sphinx-tabs#90. This is a fix we need to make on the sphinx-tabs end. Having said that I might just add groups here

@Daltz333
Copy link
Author

If tab groups do get added here, we may consider switching after tweaking some of the CSS a bit. Especially as this project seems much more maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants