Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improve documentation for shaders #3065

Closed
KokoDoko opened this issue May 17, 2024 · 1 comment
Closed

Docs: Improve documentation for shaders #3065

KokoDoko opened this issue May 17, 2024 · 1 comment
Labels
docs Relating to documentation in any way

Comments

@KokoDoko
Copy link

Context

The documentation page for post processors : https://excaliburjs.com/docs/postprocessors
doesn't seem complete.

The examples for colorblindness work

There is an example for a grayscale shader, but this is missing information on how to implement the grayscale shader.
If you just copy the colorblindness example and replace the colorblindness shader with the grayscale shader, it doesn't work.

const gray = new GrayScalePostProcessor();
game.graphicsContext.addPostProcessor(gray);

🚨 error: getShader() is not defined.

Proposal

Include code that explains how to implement the grayscale shader

@KokoDoko KokoDoko changed the title Improve documentation for shaders Docs: Improve documentation for shaders May 17, 2024
@eonarheim
Copy link
Member

@KokoDoko Totally agree!

@eonarheim eonarheim added the docs Relating to documentation in any way label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relating to documentation in any way
Projects
None yet
Development

No branches or pull requests

2 participants