Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the BoundingBox.intersect(other: BoundingBox): Vector comments positions #3010

Open
ikudrickiy opened this issue Apr 6, 2024 · 4 comments
Open

Correct the BoundingBox.intersect(other: BoundingBox): Vector comments positions #3010

ikudrickiy opened this issue Apr 6, 2024 · 4 comments
Labels
stale This issue or PR has not had any activity recently

Comments

@ikudrickiy
Copy link
Contributor

Context

All 4 multiline comments are placed incorrectly

Screenshot

image

Proposal

Correct the comments positions
@ikudrickiy
Copy link
Contributor Author

Ah, seems like it is just another comment positioning principle. Do we have a rule to follow in this question? Should we? Shouldn't we?

@ikudrickiy
Copy link
Contributor Author

Pay attention to this
#3011
first

@eonarheim
Copy link
Member

@ikudrickiy Fair point! Yah these comments are confusingly placed... this could be improved.

We'll chat about #3011 first as you say!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

This issue hasn't had any recent activity lately and is being marked as stale automatically.

@github-actions github-actions bot added the stale This issue or PR has not had any activity recently label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale This issue or PR has not had any activity recently
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eonarheim @ikudrickiy