Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension does not compile against PG16 #42

Open
maherbeg opened this issue Feb 1, 2024 · 0 comments
Open

Extension does not compile against PG16 #42

maherbeg opened this issue Feb 1, 2024 · 0 comments

Comments

@maherbeg
Copy link

maherbeg commented Feb 1, 2024

Hello!

It looks like this extension can not be compiled against Postgres 16 developer libraries. I see this error when attempting to compile the library on Debian bookworm against PG16

31.64 hamming.c:181:65: error: incompatible pointer to integer conversion passing 'char *' to parameter of type 'Datum' (aka 'unsigned long') [-Wint-conversion]
31.64         elog(DEBUG1, "hammingdistance(%s, %s) = %.3f", DatumGetCString(a), DatumGetCString(b), res);
31.64                                                                        ^
31.64 /usr/include/postgresql/16/server/utils/elog.h:239:34: note: expanded from macro 'elog'
31.64         ereport(elevel, errmsg_internal(__VA_ARGS__))
31.64                                         ^~~~~~~~~~~
31.64 /usr/include/postgresql/16/server/utils/elog.h:164:37: note: expanded from macro 'ereport'
31.64         ereport_domain(elevel, TEXTDOMAIN, __VA_ARGS__)
31.64                                            ^~~~~~~~~~~
31.64 /usr/include/postgresql/16/server/utils/elog.h:147:4: note: expanded from macro 'ereport_domain'
31.64                         __VA_ARGS__, errfinish(__FILE__, __LINE__, __func__); \
31.64                         ^~~~~~~~~~~
31.64 /usr/include/postgresql/16/server/postgres.h:335:23: note: passing argument to parameter 'X' here
31.64 DatumGetCString(Datum X)

I see that some Debian maintainers patched this in https://packages.debian.org/trixie/amd64/database/postgresql-16-similarity - Could this get upstreamed here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant