Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

estimateGas does not support eip-4844. #4728

Closed
iteyelmp opened this issue May 11, 2024 · 4 comments
Closed

estimateGas does not support eip-4844. #4728

iteyelmp opened this issue May 11, 2024 · 4 comments
Assignees
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6

Comments

@iteyelmp
Copy link

Ethers Version

6.12.1

Search Terms

No response

Describe the Problem

When obtaining the gasLimit of eip-4844 type transaction, need to bring blobVersionedHashes.

blobhash estimated gas error.

image

bytes32 dataHash = blobhash(blobIdx); require(dataHash != 0, "failed to get blob hash");

Code Snippet

No response

Contract ABI

No response

Errors

No response

Environment

Ethereum (mainnet/ropsten/rinkeby/goerli)

Environment (Other)

No response

@iteyelmp iteyelmp added investigate Under investigation and may be a bug. v6 Issues regarding v6 labels May 11, 2024
@ricmoo
Copy link
Member

ricmoo commented May 16, 2024

I believe you absolutely correct. I will experiment with this and get a fix asap.

@ricmoo ricmoo added on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. labels May 16, 2024
@ricmoo
Copy link
Member

ricmoo commented May 16, 2024

FYI, I've deployed the follow contract to sepolia:

contract TestBolb {
    function test() public view returns (bytes32) {
        bytes32 dataHash = blobhash(0);
        require(dataHash != 0, "failed to get blob hash");
        return dataHash;
    }
}

which indeed demonstrates the issue.

@ricmoo
Copy link
Member

ricmoo commented May 30, 2024

The biggest issue right now is that Etherscan's proxy API doesn't support passing hashes along. I'll contact them, but for now will throw an unsupported operations error in the event someone tries passing blobVersionedHashes along to that particular provider.

@ricmoo
Copy link
Member

ricmoo commented Jun 2, 2024

Added in v6.12.2. Let me know if you still have any issues.

Thanks! :)

@ricmoo ricmoo closed this as completed Jun 2, 2024
@ricmoo ricmoo added enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. and removed investigate Under investigation and may be a bug. on-deck This Enhancement or Bug is currently being worked on. next-patch Issues scheduled for the next arch release. labels Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement. fixed/complete This Bug is fixed or Enhancement is complete and published. v6 Issues regarding v6
Projects
None yet
Development

No branches or pull requests

2 participants