Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature details omit information about ECDSA nonces #770

Open
znewman01 opened this issue Nov 4, 2019 · 0 comments
Open

Signature details omit information about ECDSA nonces #770

znewman01 opened this issue Nov 4, 2019 · 0 comments

Comments

@znewman01
Copy link

The Appendix F ("Signing Transactions") spells out the use of recoverable ECDSA signatures, but doesn't mention how nonces are computed or included.

In particular, this creates a couple of minor problems:

  • ECDSASIGN is not a function unless the nonce is supplied, so the text is incorrect
  • the supplied reference [Johnson 2001] suggests that nonces be computed randomly, but the Go Ethereum client uses RFC 6979 deterministic signatures. One might argue that this is a choice left to the client, or one might consider it part of the specification (in particular, using deterministic nonces removes the possibility of a class of errors); either way, I think readers would benefit from a sentence of discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@znewman01 and others