Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types #116

Open
antazoey opened this issue Nov 2, 2022 · 0 comments · May be fixed by #216
Open

Add types #116

antazoey opened this issue Nov 2, 2022 · 0 comments · May be fixed by #216

Comments

@antazoey
Copy link
Contributor

antazoey commented Nov 2, 2022 •
edited

  • py-geth Version: 3.10
  • go-ethereum Version: 1.10.25-stable
  • Python Version: 3.9.13
  • OS: macOS

What was wrong?

Currently, when using py-geth as a library, we have to put type: ignore statements on all of the imports:

https://github.com/ApeWorX/ape/blob/main/src/ape_geth/provider.py#L16-L20

Adding types will help us verify we are using the library correctly as well as assist us it looks better (low priority).

Cute Animal Picture

chicken
@pacrob pacrob mentioned this issue Oct 24, 2023
Open
5 tasks
@pacrob pacrob linked a pull request Jun 5, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Typed py geth ethereum/py-geth
1 participant
@antazoey