Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem when upgrading from 2.0 to 2.3 #19

Open
elbriggs opened this issue Jun 21, 2024 · 3 comments
Open

Problem when upgrading from 2.0 to 2.3 #19

elbriggs opened this issue Jun 21, 2024 · 3 comments

Comments

@elbriggs
Copy link
Contributor

We have been using v2.0 of Tiled-MM successfully for some time but when I recently tried updating to use v2.3 we started experiencing incorrect results from our application (https://github.com/RMGDFT/rmgdft). I determined that the problematic calls were occurring with transa and transb both 'N' while calls with transa='T' and transb='N' were producing the correct results. The matrices in question were tall and skinny (m,n,k) (46656,152,480). I tried running the testing app using these values but no error was reported so I'm not sure how to proceed. I looked over the commit history and 85331eb seens to be the only thing that could have changed the behavior.

@elbriggs
Copy link
Contributor Author

Changing line 335 in that commit back to what it was previously fixed the issue.
if (k_tile_id == 0 && std::abs(beta) > 0) {
back to
if (k_tile_id == 0)

@kabicm
Copy link
Collaborator

kabicm commented Jun 23, 2024

Thanks @elbriggs, that's a good catch! Do you want to make a PR with this change?

@elbriggs
Copy link
Contributor Author

Sure. I'll do that this morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants