Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto label PRs on Github #17970

Closed
serathius opened this issue May 8, 2024 · 9 comments · Fixed by #17979
Closed

Auto label PRs on Github #17970

serathius opened this issue May 8, 2024 · 9 comments · Fixed by #17979
Assignees
Labels
area/community area/tooling help wanted priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature

Comments

@serathius
Copy link
Member

What would you like to be added?

Would be nice for PR discovery to have them automatically labeled based on directory they touch.
For example if the test touches ./tests/robustness we can always label it with area/robustness-testing.

I think K8s OWNERS support this https://go.k8s.io/owners

cc @jmhbnz

Why is this needed?

Better discovery of PRs for people interested in reviewing robustness test changes.

@jmhbnz
Copy link
Member

jmhbnz commented May 9, 2024

Agree this would be great to start bringing online. Thanks @liangyuanpeng for drafting the initial pr to enable it in kubernetes/test-infra: https://github.com/kubernetes/test-infra/pull/32589/files

For this to be helpful we do need to add nested OWNERS files with the label stanza, for example: https://github.com/kubernetes/kubernetes/blob/master/cluster/images/OWNERS

Nested OWNERS we have already discussed and have consensus to progress so I will write an initial suggestion of labels here shortly so we can raise the pr.

@jmhbnz jmhbnz self-assigned this May 9, 2024
@jmhbnz
Copy link
Member

jmhbnz commented May 9, 2024

/assign @liangyuanpeng

@k8s-ci-robot
Copy link

@jmhbnz: GitHub didn't allow me to assign the following users: liangyuanpeng.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @liangyuanpeng

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fuweid
Copy link
Contributor

fuweid commented May 9, 2024

Hi @jmhbnz , as far as I know, /lgtm command doesn't work. Is there any plan to use OWNERS file and enable /lgtm as review process?

@jmhbnz
Copy link
Member

jmhbnz commented May 9, 2024

Hi @jmhbnz , as far as I know, /lgtm command doesn't work. Is there any plan to use OWNERS file and enable /lgtm as review process?

Yes. But we need to work carefully and set up the nested OWNERS files that it would depend on. It's a gradual journey adopting the k/k prow features, want to make sure we don't try to do too much at once and cause problems. This auto labeling is a good driver for us to start creating nested OWNERS.

@serathius serathius changed the title Auto label PR on Github Auto label PRs on Github May 9, 2024
@ah8ad3
Copy link
Contributor

ah8ad3 commented May 9, 2024

Very nice feature to have let me know if i can help with anything.

@liangyuanpeng
Copy link
Contributor

/assign

@serathius
Copy link
Member Author

@jmhbnz was #17979 enough to have auto labeling working? Have you tested it?

@jmhbnz
Copy link
Member

jmhbnz commented May 13, 2024

@jmhbnz was #17979 enough to have auto labeling working? Have you tested it?

Yes it is working now, example #17983:

image

I still need to check nesting for label hierarchy but basics are working :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/community area/tooling help wanted priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. type/feature
Development

Successfully merging a pull request may close this issue.

6 participants