Fix the auto-compaction-retention logging in the startup #17986
Conversation
Signed-off-by: Akin Tekeoglu <[email protected]>
|
Hi @akin-tekeoglu. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
I see your name in the OWNERS file @fuweid. Can you take a look? |
server/embed/etcd.go
Outdated
| if sc.AutoCompactionMode == compactor.ModePeriodic { | ||
| autoCompactRetention = zap.Duration("auto-compaction-retention", sc.AutoCompactionRetention) | ||
| } else { | ||
| autoCompactRetention = zap.Int64("auto-compaction-retention", int64(sc.AutoCompactionRetention)) |
There was a problem hiding this comment.
I like this simplification for less confusion. But should we keep the name the name not to breaking existing users?
There was a problem hiding this comment.
@siyuanfoundation I made the changes. Can you take a look again?
Signed-off-by: Akin Tekeoglu <[email protected]>
|
/retest-required |
|
/retest |
| @@ -307,6 +309,12 @@ func print(lg *zap.Logger, ec Config, sc config.ServerConfig, memberInitialized | |||
| if quota == 0 { | |||
| quota = storage.DefaultQuotaBytes | |||
| } | |||
| var autoCompactionRetention zapcore.Field | |||
| if sc.AutoCompactionMode == compactor.ModePeriodic { | |||
There was a problem hiding this comment.
There is type alias for compactor.ModePeriodc in server/embed: CompactorModePeriodic.
Please consider to use switch branch because that mode can be invalid, like empty.
Fixes #17822
It seemed to me that
auto-compaction-intervalwas useless so I nuked it