New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Option to use system preference for light/dark theme #18190
Comments
I like the third button. It does seem more common too. |
ping @eslint/eslint-team |
i think we can just click on the |
I'd like to see some examples of how other sites are doing this before coming to a conclusion here. @JoshuaKGoldberg can you compile a few sites that have implemented something along the lines of what you're describing so we can evaluate? |
A few popular sites that have options on all pages, rather than in profile settings...
|
Nice, thanks! Given those, I think adding a third button with a monitor that says "System" probably makes the most sense for us. I'm also not opposed to making the "Light", "Dark", and "System" as |
Docs page(s)
all of them
What documentation issue do you want to solve?
The ESLint docs currently default to the browser's
prefers-color-scheme
setting for light/dark mode by default. And they have a Light/Dark selector to let the user specify an override.But, there's no way to remove the override: i.e. go back to the default behavior of using the browser/system preference. This feels like a bug / missing feature to me: what if the user wants go back to the system preference?
I've hit this where I've needed to change the page temporarily, but subsequently wanted to go back to synced with the browser/system preferences.
What do you think is the correct solution?
A few UI options come to mind, in order of what I think is most intuitive & usable first:
The current selector, for reference:
Participation
Additional comments
Sibling issue to #18189.
The text was updated successfully, but these errors were encountered: