Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo: Remove unused tools/update-rule-types.js #18121

Closed
JoshuaKGoldberg opened this issue Feb 16, 2024 · 2 comments · Fixed by #18125
Closed

Repo: Remove unused tools/update-rule-types.js #18121

JoshuaKGoldberg opened this issue Feb 16, 2024 · 2 comments · Fixed by #18125
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing

Comments

@JoshuaKGoldberg
Copy link
Contributor

Splitting out of #18005 (comment): it looks like tools/update-rule-types.js can be safely deleted.

Yeah, it was a one-time thing, just kept it around because we had to do several rounds before we got everything correct. It's probably safe to remove at this point.
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 16, 2024
Merged
1 task
@fasttime
Copy link
Member

Probably tools/rule-types.json is also safe to delete. Besides update-rule-types.js, that file is only referenced in Makefile.js, to make sure that it contains an entry for each rule. But at this point, since there are no other references, that check could be also safely removed.

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Feb 17, 2024
@fasttime
Copy link
Member

@JoshuaKGoldberg would you like to submit a PR for this change?

@mdjermanovic mdjermanovic added the chore This change is not user-facing label Feb 18, 2024
@mdjermanovic mdjermanovic linked a pull request Feb 18, 2024 that will close this issue
chore: remove unused tools: rule-types.json, update-rule-types.js #18125
Merged
1 task
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 18, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: remove unused tools: rule-types.json, update-rule-types.js JoshuaKGoldberg/eslint
3 participants
@JoshuaKGoldberg @fasttime @mdjermanovic