Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Some dark mode text styles missing when JavaScript is disabled #18076

Open
1 task done
JoshuaKGoldberg opened this issue Feb 2, 2024 · 1 comment
Open
1 task done
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Comments

@JoshuaKGoldberg
Copy link
Contributor

Docs page(s)

All of them, for the ESLint header
https://eslint.org/docs/latest/rules/* and other pages with syntax-highlighted code blocks

What documentation issue do you want to solve?

Several areas of pages have different -sometimes even unreadable- text when in dark mode & JavaScript is disabled. Copying examples from #16612:

JavaScript Disabled JavaScript Enabled
Screenshot of the ESLint documentation hub, showing an unreadable dark text header Screenshot of the ESLint documentation hub, showing a readable light text header
Screenshot of Configuration Files (New), showing the same dark header, and some code that has black syntax Screenshot of Configuration Files (New), showing the same header, and some code that has full syntax highlighting
Screenshot of Rules > Deprecated list, showing red text on white for deprecation notices Screenshot of Rules > Deprecated list, showing red text on dark gray for deprecation notices
Screenshot of a Warning admonition showing red text on white background Screenshot of a Warning admonition showing light red text on a dark red background
Screenshot of a Tip admonition showing green text on white background Screenshot of a Tip admonition showing light green text on a dark green background

What do you think is the correct solution?

Ideally, I'd think the same styles that normally get loaded should be used.

An alternate strategy used in those

Participation

  • I am willing to submit a pull request for this change.

Additional comments

Reported by @amareshsm in #16612 -> #18071.

@JoshuaKGoldberg JoshuaKGoldberg added the documentation Relates to ESLint's documentation label Feb 2, 2024
@amareshsm
Copy link
Member

The details addressing the issue are included in this comment. I've outlined two methods that I'm aware of to resolve the problem.

Feel free to inform me if there are any elements I might have overlooked or if there's additional information I should consider.

@amareshsm amareshsm added triage An ESLint team member will look at this issue soon accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Feb 3, 2024
@amareshsm amareshsm self-assigned this Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Implementing
Development

Successfully merging a pull request may close this issue.

2 participants