Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [playground]alert item add Disabled button. #546

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zhangenming
Copy link

@zhangenming zhangenming commented Apr 8, 2024

Prerequisites checklist

What is the purpose of this pull request?

we can Disabled an rule quickly.

What changes did you make? (Give an overview)

image

Related Issues

fixes #548

Is there anything you'd like reviewers to focus on?

The css style is a little newbie not perfect sorry

Copy link

linux-foundation-easycla bot commented Apr 8, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/66175f17ed1efd00082f54e4
😎 Deploy Preview https://deploy-preview-546--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/66175f1729ba6800081cbbc1
😎 Deploy Preview https://deploy-preview-546--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/66175f17e9498e0008a95740
😎 Deploy Preview https://deploy-preview-546--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit f3215ba
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/6613f10e8897e20007281d01
😎 Deploy Preview https://deploy-preview-546--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit f3215ba
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/6613f10e4e0c880007d318ba
😎 Deploy Preview https://deploy-preview-546--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit f3215ba
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/6613f10e8897e20007281d03
😎 Deploy Preview https://deploy-preview-546--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/66175f17408adb000877a62d
😎 Deploy Preview https://deploy-preview-546--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/66175f17e757d900089edf70
😎 Deploy Preview https://deploy-preview-546--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/66175f177d61bf0008726b20
😎 Deploy Preview https://deploy-preview-546--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/66175f17591c240007c724a5
😎 Deploy Preview https://deploy-preview-546--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 9d2b803
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/66175f17225426000821cff2
😎 Deploy Preview https://deploy-preview-546--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm
Copy link
Member

@zhangenming pls create an issue explaining what problem you are trying to solve and the solution you would like to implement. ESlint team will triage the issue and mark it as accepted if the team agrees.

@amareshsm amareshsm added triage and removed triage labels Apr 8, 2024
@zhangenming zhangenming changed the title feat: alert item add Disabled button. feat: [playground]alert item add Disabled button. Apr 9, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it could be useful, but I'd like some other reviews from @eslint/eslint-team before merging.

src/playground/components/Alert.js Outdated Show resolved Hide resolved
display: "flex"
}}>
{ fix && (
<button onClick={() => onFix(message)} className="alert__fix-btn" style={{ "border-radius": 0 }}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<button onClick={() => onFix(message)} className="alert__fix-btn" style={{ "border-radius": 0 }}>
<button onClick={() => onFix(message)} className="alert__fix-btn">

Pls, avoid inline style. Try to add style to the existing class.

Comment on lines +73 to +75
<div style={{
display: "flex"
}}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div style={{
display: "flex"
}}>
<div className="alert__actions">

Pls, avoid inline style. Create a class and add styles to that class.

In the alert.scss style file:

.alert__actions {
 display: flex:
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Evaluating
Development

Successfully merging this pull request may close these issues.

Suggestion: [playground]alert item add Disabled button.
3 participants