Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: [playground]alert item add Disabled button. #548

Open
1 task done
zhangenming opened this issue Apr 9, 2024 · 5 comments · May be fixed by #546
Open
1 task done

Suggestion: [playground]alert item add Disabled button. #548

zhangenming opened this issue Apr 9, 2024 · 5 comments · May be fixed by #546
Labels
accepted enhancement New feature or request

Comments

@zhangenming
Copy link

What problem do you want to solve?

we can Disabled an rule quickly.

What do you think is the correct solution?

add Disabled button.

Participation

  • I am willing to submit a pull request for this change.

Additional comments

No response

@zhangenming zhangenming added the enhancement New feature or request label Apr 9, 2024
@zhangenming zhangenming linked a pull request Apr 9, 2024 that will close this issue
@zhangenming zhangenming changed the title Suggestion: alert item add Disabled button. Suggestion: [playground]alert item add Disabled button. Apr 9, 2024
@nzakas
Copy link
Member

nzakas commented Apr 10, 2024

Thanks for submitting this. While I understand what you're going for, the point of filing an issue is to provide details as to what change you'd like to make and why you'd like to make it. One sentence really isn't enough for us to evaluate.

@zhangenming
Copy link
Author

zhangenming commented Apr 11, 2024

what change you'd like to make

add a button like this
image

why you'd like to make it.

can quickly remove rules that I know I don't want

@nzakas
Copy link
Member

nzakas commented Apr 11, 2024

Seems reasonable to me, although the button should be labeled "Disable" or maybe "Ignore"?

And not sure if we should just remove it from the configuration or set to "off".

Would like some thoughts from @eslint/eslint-team

@snitin315
Copy link
Contributor

I think the label should be Disable and we should turn it off instead of removing from the config.

@mdjermanovic
Copy link
Member

If we'd add a "Config" button that would scroll to the rule's config, as proposed in #550, then we might not need this button as the user can there easily remove it or set it to "off", whichever they prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted enhancement New feature or request
Projects
Status: Implementing
Development

Successfully merging a pull request may close this issue.

4 participants