feat!: bump mdast-util-from-markdown with synckit
#229
Conversation
JounQin
changed the title
mdast-util-from-markdown with synckit
|
We don't want to drop Node 12 until we release ESLint v9, which will also drop Node.js 12. Is there a reason we can't use mdast-util-from-markdown 0.8.5 for now? |
|
It requires outdated unified related packages may results conflict/duplicate dependencies. |
|
Okay, We'll still need to wait until ESLint v9 to drop Node.js 12 support. At that point, we need to update Node.js support for all packages. |
|
|
Friendly ping @nzakas |
|
We just released ESLint v9.0.0-alpha, so I think we can formally update the Node.js support for this package now. Can you submit a PR like this? eslint/eslint-scope#115 |
|
Wow, that's really a big change, I was thinking to keep compatible, not ESLint v9 only. Because in case the big breaking changes on eslint v9, I believe the migration could be very slow. |
|
@nzakas Any further discussion? |
|
@JounQin it has dropped node.js < 18 supports. what's the next steps here? |
|
@aladdin-add Didn't notice that, I've updated the PR accordingly. |
|
At this point, I don't think we should move further with this PR. It's not fixing any bugs and adding in a new dependency just to upgrade some other module doesn't seem like a good tradeoff. |
close #218, drop node 12
mdast-util-from-markdownis ESM only now,synckitmakes it possible to require ESM only module in commonjs withoutawait import().cc @btmills @nzakas