From 5dfc88872838184c9627bf868b303379cb95d45a Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:37:58 +0000 Subject: [PATCH 1/8] creating a pull request template --- .github/templates/pull_request_template.md | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) create mode 100644 .github/templates/pull_request_template.md diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md new file mode 100644 index 000000000..68a60c04d --- /dev/null +++ b/.github/templates/pull_request_template.md @@ -0,0 +1,21 @@ +Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed +- [] Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) +- [] Have you written new tests for your core changes, as applicable? +- [] Have you successfully ran tests with your changes locally? + +**Description** + +Write a short description here... + +**Changes to be made** + +How do you intend to go about getting this done... + +**Status** +What have you done so far... + +**To do** +If this is a work in progress, what are your next steps? + +Is this pull request related to any open issue? If yes, replace issueID below with the issue ID +Related to # \ No newline at end of file From 65a658466876703b4156100361fab285c3294017 Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:46:00 +0000 Subject: [PATCH 2/8] making changes --- .github/templates/pull_request_template.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index 68a60c04d..0f0809e10 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -1,7 +1,7 @@ Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed -- [] Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) -- [] Have you written new tests for your core changes, as applicable? -- [] Have you successfully ran tests with your changes locally? +- [X] Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) +- [X] Have you written new tests for your core changes, as applicable? +- [X] Have you successfully ran tests with your changes locally? **Description** @@ -12,9 +12,11 @@ Write a short description here... How do you intend to go about getting this done... **Status** + What have you done so far... **To do** + If this is a work in progress, what are your next steps? Is this pull request related to any open issue? If yes, replace issueID below with the issue ID From ca7a3e332392ed58dd410aa13f48f2afb309c1fd Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:47:42 +0000 Subject: [PATCH 3/8] making changes --- .github/templates/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index 0f0809e10..45229d236 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -1,7 +1,7 @@ Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed -- [X] Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) -- [X] Have you written new tests for your core changes, as applicable? -- [X] Have you successfully ran tests with your changes locally? +- [X] - Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) +- [X] - Have you written new tests for your core changes, as applicable? +- [X] - Have you successfully ran tests with your changes locally? **Description** From d1ff7d33df40152ee39cb11b0648bf7cd487d8be Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:49:57 +0000 Subject: [PATCH 4/8] making changes --- .github/templates/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index 45229d236..be7a81d43 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -1,7 +1,7 @@ Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed -- [X] - Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) -- [X] - Have you written new tests for your core changes, as applicable? -- [X] - Have you successfully ran tests with your changes locally? +- [] - Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) +- [] - Have you written new tests for your core changes, as applicable? +- [] - Have you successfully ran tests with your changes locally? **Description** From 892294869a663dd48a1d43481e250a2c21e97c7a Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:52:04 +0000 Subject: [PATCH 5/8] making changes --- .github/templates/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index be7a81d43..18bc45f19 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -5,19 +5,19 @@ Thank you for taking your time to contribute to Ersilia, just a few checks befor **Description** -Write a short description here... +Replace this line with a short description here... **Changes to be made** -How do you intend to go about getting this done... +Replace this line with how do you intend to go about getting this done... **Status** -What have you done so far... +Replace this line with what you have done so far... **To do** -If this is a work in progress, what are your next steps? +If this is a work in progress, Replace this line with your next steps Is this pull request related to any open issue? If yes, replace issueID below with the issue ID Related to # \ No newline at end of file From c51f71a2762bcb93b3b70380bac7ee25034e269f Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:57:22 +0000 Subject: [PATCH 6/8] making changes --- .github/templates/pull_request_template.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index 18bc45f19..535f9d231 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -1,7 +1,7 @@ Thank you for taking your time to contribute to Ersilia, just a few checks before we proceed -- [] - Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) -- [] - Have you written new tests for your core changes, as applicable? -- [] - Have you successfully ran tests with your changes locally? +- [ ] Have you followed the guidelines in our [Contribution Guide](https://github.com/ersilia-os/ersilia/blob/master/CONTRIBUTING.md) +- [ ] Have you written new tests for your core changes, as applicable? +- [ ] Have you successfully ran tests with your changes locally? **Description** From 2016af599ba88e91501236aec881da9b883634b6 Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 12:58:52 +0000 Subject: [PATCH 7/8] making changes --- .github/templates/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index 535f9d231..3465721ea 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -20,4 +20,5 @@ Replace this line with what you have done so far... If this is a work in progress, Replace this line with your next steps Is this pull request related to any open issue? If yes, replace issueID below with the issue ID + Related to # \ No newline at end of file From fb6bb302a4df6630ce4120cc00887d40dbc98acd Mon Sep 17 00:00:00 2001 From: ADEYEMI Jumoke Olantun Date: Thu, 27 Jun 2024 13:00:57 +0000 Subject: [PATCH 8/8] making changes --- .github/templates/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/templates/pull_request_template.md b/.github/templates/pull_request_template.md index 3465721ea..f875a250e 100644 --- a/.github/templates/pull_request_template.md +++ b/.github/templates/pull_request_template.md @@ -5,19 +5,19 @@ Thank you for taking your time to contribute to Ersilia, just a few checks befor **Description** -Replace this line with a short description here... +_Replace this line with a short description here..._ **Changes to be made** -Replace this line with how do you intend to go about getting this done... +_Replace this line with how do you intend to go about getting this done..._ **Status** -Replace this line with what you have done so far... +_Replace this line with what you have done so far..._ **To do** -If this is a work in progress, Replace this line with your next steps +_If this is a work in progress, Replace this line with your next steps_ Is this pull request related to any open issue? If yes, replace issueID below with the issue ID