Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: Test on Colab workflow keeps timing out and ends up failing. #978

Open
DhanshreeA opened this issue Mar 5, 2024 · 2 comments
Labels
bug Something isn't working low Can be deprioritized in favor of other issues; can be picked up by new contributors

Comments

@DhanshreeA
Copy link
Member

DhanshreeA commented Mar 5, 2024

Describe the bug.

GitHub runners by default a time limit of 6 hours. A job that takes longer than that fails because it gets canceled. The Test on Colab workflow seems to be stuck(?) and keeps running until the job automatically gets canceled. We will need to investigate this.

Describe the steps to reproduce the behavior

No response

Expected behavior.

No response

Screenshots.

No response

Operating environment

NA

Additional context

No response

@DhanshreeA DhanshreeA added the bug Something isn't working label Mar 5, 2024
@miquelduranfrigola
Copy link
Member

I don't know what is happening to be honest. This is annoying and I am unsure whether it is related to Ersilia or not. Actually, it is not testing "Colab" per se, it is just testing the notebook. In my opinion, this test may eventually disappear since it periodically fails for some reason.

@DhanshreeA
Copy link
Member Author

In the last discussion we came to the conclusion that currently the workflow is not representative of actually testing anything on Colab. It is also likely that the action times out because within the notebook we are fetching a model that hasn't been rebuilt and fails to fetch, which leaves ersilia hanging and therefore the entire workflow times out.

In any case, we have decided to redo this workflow to test a notebook in an actual Colab environment, something like this SO post: https://stackoverflow.com/questions/77437999/google-colab-environment-container-testing-in-github-action

@DhanshreeA DhanshreeA added the low Can be deprioritized in favor of other issues; can be picked up by new contributors label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low Can be deprioritized in favor of other issues; can be picked up by new contributors
Projects
Status: Queue
Development

No branches or pull requests

2 participants