Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃搼 Feature Request: Migrate from Dockerfile to YAML in the configuration of models #743

Closed
miquelduranfrigola opened this issue Jul 10, 2023 · 3 comments
Labels
duplicate This issue or pull request already exists enhancement New feature or request

Comments

@miquelduranfrigola
Copy link
Member

Is your feature request related to a problem? Please describe.

Having model configuration as Dockerfile in the model repositories (see template) is confusing, since many times docker is not used for installation. I have realized that many contributors are confused by this fact and, therefore, we need to find a more intuitive solution.

Describe the solution you'd like.

Possibly, having a config.yml file would be the ideal solution. This should not cause a lot of friction since, at fetch time, we can incorporate the commands of this file into a Dockerfile internally, and proceed as usual.

Describe alternatives you've considered

No response

Additional context.

No response

@miquelduranfrigola miquelduranfrigola added the enhancement New feature or request label Jul 10, 2023
@russelljeffrey
Copy link

Hi @miquelduranfrigola,
Based on what I understood, I think somebody has already resolved this type of issue in here. The answer takes you to a github repo that can convert docker file to YAML file in bash(shell). You can find the github repo here. Let me know if it works.

@GemmaTuron
Copy link
Member

This issue is linked to that one: #749 and that one: #746
I'll keep the discussion just here for simplicity and close the other issues - this feature incorporation has been deprioritized and will be worked out in the next Ersilia big release

@DhanshreeA
Copy link
Member

Marking this issue as duplicate and closing it since we are more proactively addressing this in #1159

@DhanshreeA DhanshreeA closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants