Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml file #1153

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

dzumii
Copy link
Contributor

@dzumii dzumii commented Jun 6, 2024

Description
Having removed pandas from the tracking functionality, it was necessary to remove it entirely from the setup (pyproject.toml) file and compare the time it takes to build the base image

Changes Made

  • removed pandas block from pyproject.toml file

To do

  • compare build time before removing pandas with the time after pandas has been removed

Status
Work in Progress

Related to #1131 #1090

@dzumii
Copy link
Contributor Author

dzumii commented Jun 6, 2024

I have updated the file and made comparison.
However, i can't seem to notice so much changes, as it took almost the same time to build the image (133.7s on codespace) before i removed pandas and 133.1s after I removed pandas

@DhanshreeA

@DhanshreeA
Copy link
Member

Interesting, let me give it a try @dzumii

@DhanshreeA
Copy link
Member

@dzumii I think you'll need to modify the Dockerfile slightly on your branch to build an image, but please change it back to as it was before when you push. The modification you'll need to make involves cloning ersilia at your branch because right now it's still building from the main branch. Does this make sense? It's a bit of a hack and not ideal.

@dzumii
Copy link
Contributor Author

dzumii commented Jun 6, 2024

Oh, thanks, let me try it out

@dzumii
Copy link
Contributor Author

dzumii commented Jun 6, 2024

@dzumii I think you'll need to modify the Dockerfile slightly on your branch to build an image, but please change it back to as it was before when you push. The modification you'll need to make involves cloning ersilia at your branch because right now it's still building from the main branch. Does this make sense? It's a bit of a hack and not ideal.

I have done this and the build time without Pandas is now about 120s (that is like 19% reduction)

@DhanshreeA DhanshreeA merged commit a694a5b into ersilia-os:master Jun 7, 2024
16 checks passed
@DhanshreeA
Copy link
Member

Okay I can confirm the builds take significantly less now: ~7 minutes from ~1.5 hours.

@dzumii dzumii deleted the update-pyproject-toml branch June 23, 2024 15:02
@dzumii dzumii restored the update-pyproject-toml branch June 23, 2024 15:02
@dzumii dzumii deleted the update-pyproject-toml branch June 23, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants