Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[馃悤 Batch]: Improve versioning in Docker builds #1069

Open
DhanshreeA opened this issue Mar 13, 2024 · 1 comment
Open

[馃悤 Batch]: Improve versioning in Docker builds #1069

DhanshreeA opened this issue Mar 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@DhanshreeA
Copy link
Member

DhanshreeA commented Mar 13, 2024

Summary

Right now all our Docker images are tagged "latest" by default. This is quite problematic, since we cannot roll back to a version we knew worked (especially since we don't have tests for the builds themselves). Another reason why this would have been nice to have is for sake of comparison around size differences between older builds and the new slimmer builds. I reckon this would not be entirely easy to implement since the ersilia cli isn't tag aware and always pulls the latest tag.

Objectives

###Documentation

@DhanshreeA DhanshreeA added the bug Something isn't working label Mar 13, 2024
@miquelduranfrigola
Copy link
Member

miquelduranfrigola commented Mar 18, 2024

We decided:

  1. Versioning Ersilia base image (and other images created with the corresponding GitHub Action in the ersilia CLI repo). Version should be in synch with the actual ersilia version. The latest tag should continue to exist.
  2. Models will be versioned with a timestamp (e.g. 2024.03.18).
  3. The version of the ersilia base image used for building the model will be implicit and can be queried at model building time. Importantly, the FROM ersiliaos/ersilia:latest used at model building time should be replaced to use the exact version of the ersilia base image. This should be done dynamically in the GitHub Action.
  4. We should add a flag to the ersilia fetch command (e.g. --version 2024.03.18) in case users want to use an older version of the model.

@DhanshreeA DhanshreeA changed the title 馃悰 Bug: Improve versioning in Docker builds [馃悤 Batch]: Improve versioning in Docker builds May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Queue
Development

No branches or pull requests

2 participants