Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug: BentoML artifacts can create issues with model Docker image because of caching #1051

Closed
DhanshreeA opened this issue Mar 11, 2024 · 3 comments
Assignees
Labels
bug Something isn't working medium Useful issue or future roadmap, and needs attention

Comments

@DhanshreeA
Copy link
Member

Describe the bug.

With the introduction of multi stage builds, we keep only the necessary artifacts from a builder base image in the final model image. One of these artifacts is a bentoml database that bentoml uses to track model bundles. Because of Docker's caching mechanism, it can happen that docker has cached the layer which copies bentoml in the model image. This cached step can reference an older bundle which may not be the bundle that actually exists within the file system of the image. This makes bentoml not be able to serve the model. The larger effect is that since ersilia serve command within the container keeps retrying to reach the model server which is not running, which makes the docker container not start, which propagates to the ersilia serve command outside of the container being stuck as well.

Describe the steps to reproduce the behavior

No response

Expected behavior.

I suppose one of the possible solutions is to check during image build that the bundle name in the bentoml database is the same as the bundle that exists on the filesystem, and update it if it's not.

Screenshots.

No response

Operating environment

NA

Additional context

No response

@DhanshreeA DhanshreeA added the bug Something isn't working label Mar 11, 2024
@DhanshreeA DhanshreeA self-assigned this Mar 11, 2024
@DhanshreeA DhanshreeA added the medium Useful issue or future roadmap, and needs attention label Mar 11, 2024
@miquelduranfrigola
Copy link
Member

Thanks @DhanshreeA - anything you need from me immediately?

@DhanshreeA
Copy link
Member Author

Not right now @miquelduranfrigola , thanks!

@DhanshreeA
Copy link
Member Author

This has not been reproducible. Closing as not planned for now.

@DhanshreeA DhanshreeA closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working medium Useful issue or future roadmap, and needs attention
Projects
Status: Done
Development

No branches or pull requests

2 participants