Exceptions not working in substitution extension?

[daobrien]

I have a fairly basic substitution rule, designed to catch any erroneous use of "login". We use "log in" as a verb and "login" as a noun and adjective.

The style currently looks like this (very much WIP):

---
extends: substitution
message: "Use '%[1]s' instead of '%[2]s'"
level: error
ignorecase: true
# swap maps tokens in form of bad: good
swap:
  "login (?:as|to)": log in as
  "log into": log in to
  "logout (?:of|from)": log out of
# Don't catch these
exceptions:
  - "default login to "
  - "When login to"

It needs mods because I can't capture and replace the way I want, but that's another story.

As it stands, the exceptions appear not to work. In a test file that contains "Set the default login to user." the rule still catches "login to". I don't know why.

I tried using NLP for this rule but it's not reliable or accurate enough to achieve the required results.

Any ideas on what I might be doing wrong? Thanks a lot.

[jdkato]

The exceptions don't work because they include words that will never be matched: when you're trying to apply the exception of default login to, it's being compared to login to.

You either need to include the preceding word in the pattern or use a negative lookbehind ((?<!default|when) login (?:as|to)).

[daobrien]

I'm trying this today. Thanks very much.

[daobrien]

This seems to work:

swap:
  (?<!when |initial |a |default |root |your )login: log in
  you login: you log in
  log into: log in to
  logout (?:off|from): log out of
  logging into: logging in to
  logging out from: logging out of

I had to fiddle it about a bit, and without being able to capture groups I had to write extra tests (hint hint 😄 ) but it seems to be doing all the right things.

Thanks again.

[jdkato]

I don't understand how using capture groups would change the experience here. Could you give an example?

[daobrien]

Probably confusing because the final style has a bit more to it, sorry.

E.g., in the strings "login to" and "login as", "login" is incorrect in both cases. Ideally, I'd replace them with "log in to" or "log in as", both of which are correct in different places. If I used login (?:to|as) and I could actually capture that group then I could replace the entire string with log in $1 (or whatever the correct syntax would be).

E.g., the following are correct:
"Log in to my-server"
"Log in as root"

hth