Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support contigous vector of doubles in ecl_sum_data_add_new_tstep() #811

Open
berland opened this issue Mar 16, 2021 · 0 comments
Open

Support contigous vector of doubles in ecl_sum_data_add_new_tstep() #811

berland opened this issue Mar 16, 2021 · 0 comments

Comments

@berland
Copy link
Contributor

berland commented Mar 16, 2021

For speed reasons, there should be a version of ecl_sum_data_add_new_tstep() that can take a contiguous vector of doubles.

The current code takes one value at a time, and performs index buiding each time. This results in slowness when f.ex. EclSum objects are created from numpy vectors/pandas dataframes.

https://github.com/equinor/ecl/blob/265dd23808f3987c38802b018f361b2fe0f317a6/lib/ecl/ecl_sum_data.cpp#L673-L678

Fixing this might create a possibility for test code that creates EclSum objects on the fly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant