Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Recast error to be more informative. #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MegaAnda123
Copy link
Collaborator

@MegaAnda123 MegaAnda123 commented Jun 24, 2024

NB: I DO NOT LIKE THIS SOLUTION (open to suggestions).

This is a lazy solution ideally welseg and compseg should be validated properly but the code is so spaghetti its almost impossible to compare the two values.

Description

Recast error to be more informative.

Why

The motivation for the change (if applicable)

How

How the change is implemented (if it's not self evident in the diff)

Close: #51

Checklist:

Before submitting this PR, please make sure:

  • I am complying with the contributing doc
  • My code builds clean without any errors or warnings
  • I have added/extended tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation, and it builds correctly

This is a lazy solution ideally welseg and compseg should be validated properly but the code is so spaghetti its almost impossible to compare the two values.
@MegaAnda123 MegaAnda123 self-assigned this Jun 24, 2024
@MegaAnda123 MegaAnda123 requested a review from a team as a code owner June 24, 2024 15:10
Copy link

@cutn94 cutn94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the validation is done in input_validation.py? From line 104 or line 127 in input_validation.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error missing completion and well segmentation
2 participants