Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--exclude is not used for --count #24

Open
mikeckennedy opened this issue Apr 2, 2024 · 3 comments
Open

--exclude is not used for --count #24

mikeckennedy opened this issue Apr 2, 2024 · 3 comments

Comments

@mikeckennedy
Copy link

There are a few directories inserted by macOS that I cannot control. But they also do not exist. I'd like to be able to write commands like:

justpath --exclude somedir --count

But --count reports 3 missing directories, even though those directories contain somedir text.

Thanks for the cool util.

@epogrebnyak
Copy link
Owner

Thanks for hosting the podcast, will need to have a look at the recording.

Will check out the --count and --exclude order, thanks for bringing that in!

@mikeckennedy
Copy link
Author

You're welcome and thanks for having a look at the combo of those two params.

@epogrebnyak
Copy link
Owner

epogrebnyak commented Apr 7, 2024

Originally, --count was a standalone command and overall intent was to show the stats for the PATH, so that a user might get a big picture of how many direcotries are there. It is possible to combine -- count with --include and --exclude flag, then the --count flag would act more like a finaliser, similar to adding | wc -l at the end of some command.

Will need to change the wording of output, now it says "n directories on your PATH", should either be just "n directories" or "n directories on your PATH (after flags)". The current message refers directly to whole PATH and I would need to change it (just keeping note).

@epogrebnyak epogrebnyak added this to the --count flag as finalizer milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants