Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing docs for Options in node sdk #90

Open
sergeysolovev opened this issue Sep 16, 2023 · 2 comments
Open

Missing docs for Options in node sdk #90

sergeysolovev opened this issue Sep 16, 2023 · 2 comments

Comments

@sergeysolovev
Copy link

Hello,

it would be amazing (for better DX) to have a few words about each setting using basic JSDoc. I would say the required minimum is to specify the default value of nullable fields (all of them are nullable). Otherwise it’s difficult to say, how shouldCache (and alike) works if I don’t pass anything.

export type Options = {
  /** ... */
  permitted?: string[];
  /** ... */
  shouldCache?: boolean;
  dotEnvFile?: string;
  memCache?: boolean;
  cwd?: string;
  onChange?: (
    updatedEnv: Record<string, string>,
    previousEnv: Record<string, string>,
    keysUpdated: string[]
  ) => void;
};
@danenania
Copy link
Contributor

Good idea, thanks @sergeysolovev. We'll get this added in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants