-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
middleware causes exceptions to not be raised/handled silently #1977
Labels
bug
Something isn't working
Comments
I'm experiencing this issue as well since the upgrade to starlette >= 0.28. I suspect this is linked to #2026? I just ran the example above for those two cases:
I note that in the second case, the INFO logger does not show the full path ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #1976
Originally posted by fraser-langton December 6, 2022
From issue in FastAPI - issue was said to be from starlette
Was initially noticed in FastAPI 0.74.0, was fixed after 0.79.0 but has since regressed (FastAPI 0.88.0 it isn't working)
When exceptions are raised on a subapp, the exceptions are not propagated all the way to see in console
In the example code
/info raises an exception and the full stacktrace is seen in console
/private/info does not raise the exception and only
INFO: 127.0.0.1:56308 - "GET /info HTTP/1.1" 500 Internal Server Error
is shown in consoleThe text was updated successfully, but these errors were encountered: