-
-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor test cases that import from private namespace. #2492
Labels
refactor
Issues and PRs related to code refactoring
Comments
This was referenced Dec 6, 2022
Similar... can we also avoid/drop uses of |
This was referenced Dec 6, 2022
Reminder to self... Cases currently still left are these:
|
This was referenced Feb 4, 2023
I pushed a bunch of PRs which get most of the remaining refactoring done. The last bits are in |
Follow up from my previous comment...
|
YDX-2147483647
added a commit
to YDX-2147483647/httpx
that referenced
this issue
Sep 16, 2023
3 tasks
Only
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have some test cases that import from private namespace inside
httpx
.This is clearly a code-smell, because our test cases ought to be tests against our public API, rather than testing implementation details. Perhaps there's some cases where it's a necessary hack, but... perhaps not?
It'd be worthwhile reviewing if we're able to remove all the cases where we're doing this. I'd suggest that any pull requests resolving this are handled on a one-module-at-a-time basis.
The text was updated successfully, but these errors were encountered: