Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX inefficiency: folder is created even if there is no content harvested #47

Open
kmmanoj opened this issue Feb 9, 2020 · 1 comment

Comments

@kmmanoj
Copy link

kmmanoj commented Feb 9, 2020

Unlike pinned messages, if the passwords, aws-keys.txt, private-keys, urls are not found it is not acknowledged properly.
In case of specific harvesting, such as for example only credential-scan an empty folder is created inspite of no harvested data.

Steps to reproduce

  • Replace CREDENTIAL_REGEX with a random value such that it does not match any message.
    CREDENTIAL_REGEX=r"lorem ipsum xyz abc mno"
    CREDENTIALS_REGEX = r"(?i)(" \

    and replace CREDENTIALS_QUERIES with random value.
    CREDENTIALS_QUERIES = ["lorem"]
    CREDENTIALS_QUERIES = ["password:", "password is", "pwd", "passwd"]
  • Run $ ./SlackPirate.py --token xoxs-xxxxx --credential-scan
  • Observe creation of a new folder but no passwords.txt created.
@kmmanoj
Copy link
Author

kmmanoj commented Feb 9, 2020

A solution that I can think of is:
Before returning the control back to the main function, a cleanup function can remove the empty files and directories created as part of the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant