Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should PreparedApp#dir be readonly? #9

Open
NullVoxPopuli opened this issue May 25, 2023 · 0 comments
Open

Should PreparedApp#dir be readonly? #9

NullVoxPopuli opened this issue May 25, 2023 · 0 comments

Comments

@NullVoxPopuli
Copy link

saw https://github.com/ef4/scenario-tester/blob/main/index.ts#L169
and that's a mutable field.
But given the usage and the fact that a Project errors if you change baseDir after it's created, I think it makes sense to have PreparedApp#dir also be read only?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NullVoxPopuli