Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support monorepos (or running commands in linked dependencies) #5

Open
NullVoxPopuli opened this issue Mar 10, 2022 · 2 comments
Open

Comments

@NullVoxPopuli
Copy link

This came up in this PR: embroider-build/embroider#1126 (review)

Where I'm trying to build a library that is linked to an app.

The issue is that I can't seem to run rollup in the linked addon and have those assets available to the PreparedApp.

execute, exists on the app, but is not available for linked packages.

@ef4 suggested this API:

await app.inDependendency('v2-addon').execute('yarn rollup -c ./rollup.config.mjs')

which seems reasonable 🤷

@ef4
Copy link
Collaborator

ef4 commented Mar 13, 2022

Small clarifying point: monorepo or not doesn't have any bearing on this. scenario-tester shouldn't be able to tell whether you're in a monorepo or not. But yes, the feature is having a convenient way to execute commands inside one of the project's dependencies, not just in the top-level project itself.

@krisselden
Copy link
Collaborator

@NullVoxPopuli I believe this is because the base project didn't linkBins before inside the tmp dir, so it relied on the outside projects node_modules/.bin.

This should be fixed in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants