Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce API to allow objects to "opt out" of introspection on specific properties. #1110

Open
rwjblue opened this issue Dec 18, 2019 · 1 comment

Comments

@rwjblue
Copy link
Member

rwjblue commented Dec 18, 2019

In #1106, we introduced a obj instanceof GlimmerComponent style check because @glimmer/[email protected] includes a few properties that throw errors when accessed (they are not intended to be used in Ember, and we provide helpful errors so that folks don't try to use them due to typing inconsistencies between Ember and Glimmer.js). In order to remove our special exemption for @glimmer/component I'd like to propose adding a mechanism that can be used to instruct the ember-inspector to completely ignore specific properties.

Off the top of my head, I have two proposed solutions here:

  • allow objects to add an __emberInspectorIgnore property as an array of property names to ignore
  • have the ember-inspector add a "well known function" to the global that can be used to register these instructions directly with the inspector

Either of these would work, or we can pick another path, but I'd like to decide a resolution so that we can remove the need to special case @glimmer/component as done in #1106.

@patricklx
Copy link
Collaborator

I guess this is fixed by the linked PR? There would also have been this possiblity: https://github.com/emberjs/ember-inspector/wiki/customize-debug-info-of-components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants