Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making Telemetry optional instead of default #282

Closed
rajasegar opened this issue Mar 30, 2020 · 4 comments · Fixed by #287
Closed

Making Telemetry optional instead of default #282

rajasegar opened this issue Mar 30, 2020 · 4 comments · Fixed by #287
Labels
enhancement New feature or request

Comments

@rajasegar
Copy link
Member

rajasegar commented Mar 30, 2020

There are a lot of issues being reported with Telemetry, and especially for addons, I am not quite sure how it will work. So I am thinking to make this optional using a command-line flag something like --telemetry=true. By default, the value of this flag will be false, i.e., telemetry will be disabled.

So without telemetry (default) :

npx ember-angle-brackets-codemod  ./path/of/files/ or ./some**/*glob.hbs

With telemetry

npx ember-angle-brackets-codemod --telemetry=true http://localhost:4200 ./path/of/files/ or ./some**/*glob.hbs

Related issues:
#274
#243
#242
#217
#200

I really need some consensus and discussion from the collaborators, before starting to work on this.
@rwjblue @Turbo87 @tylerturdenpants Your thoughts?

@Turbo87
Copy link
Collaborator

Turbo87 commented Mar 30, 2020

I would suggest --telemetry=http://localhost:4200 to simplify the CLI options, but I generally agree that the telemetry tends to be a bit finicky and that it makes sense to have this codemod also run reasonably well if telemetry is not available.

@rwjblue
Copy link
Member

rwjblue commented Apr 3, 2020

Ya, agree, we just need to nail down what the actual semantics should be (so that we fallback to doing something that is still safe and useful).

@Turbo87
Copy link
Collaborator

Turbo87 commented Apr 3, 2020

@rwjblue at some point this codemod didn't use telemetry yet, maybe we should go back to that state if telemetry is not available?

@Turbo87 Turbo87 added the enhancement New feature or request label Apr 3, 2020
Copy link
Member

rwjblue commented Apr 3, 2020

Yep, I agree I just want to be clear about what features are telemetry only (documented in the README) and ensure that the guards throughout the code are clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants