Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockStatement not migrated #208

Open
Turbo87 opened this issue Dec 14, 2019 · 11 comments
Open

BlockStatement not migrated #208

Turbo87 opened this issue Dec 14, 2019 · 11 comments
Labels
bug Something isn't working

Comments

@Turbo87
Copy link
Collaborator

Turbo87 commented Dec 14, 2019

I don't know why, but the following snippet was not converted correctly. The code lived inside another block that was correctly converted.

          {{#rl-dropdown-toggle tagName="a" class="dropdown"}}
            {{svg-jar "sort"}}
            {{ currentSortBy }}
            <span class='arrow'></span>
          {{/rl-dropdown-toggle}}
@Turbo87 Turbo87 added the bug Something isn't working label Dec 14, 2019
@tylerturdenpants
Copy link
Collaborator

Wooo a new bug to squash. I’ll try to take a look at it this weekend.

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 14, 2019

@tylerturdenpants
Copy link
Collaborator

@Turbo87 I spoke too soon. Deleting previous comment.

@tylerturdenpants
Copy link
Collaborator

Ok, so I was right, because crates.io runs [email protected], there are functions missing in the meta that fail to be captured during enumeration. I will add a guard in telemetry helpers for these functions

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 17, 2019

hmm, good point. I'm not sure in which scenario I tried to run the codemod, because I do have a branch that updates the project to 3.15 😅

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 17, 2019

hold on, this is a block statement, can that be anything other than a component invocation? (except for if/each)

@tylerturdenpants
Copy link
Collaborator

I can give you the DEBUG info in a few hours to show you that although the module for the component is there, evaluating it causes an error, and therefore never makes it to the component types array in the telemetry

@tylerturdenpants
Copy link
Collaborator

tylerturdenpants commented Dec 17, 2019

Plus the telemetry code doesn't certify a particular block mustache statement as valid component invocation even though it is. I'd have to enhance the codemod to apply these heuristics. A PR such as this would be awesome from a skilled programmer such as yourself... 😁

@Turbo87
Copy link
Collaborator Author

Turbo87 commented Dec 17, 2019

yeah, I think we only should rely on the telemetry data in ambiguous cases :)

Copy link
Member

rwjblue commented Dec 20, 2019

Agree.

@tylerturdenpants
Copy link
Collaborator

tylerturdenpants commented Dec 20, 2019

@rwjblue I agree too... but I'm trying to find the time! 😄 Busy holiday stuff, work, and family.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants