-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] require-computed-macros can autofix to self-referential macros #1118
Comments
I wonder if it's worth creating a separate rule |
@bmish for the first example, absolutely. But since an existing rule also modifies that first example we'd have to make sure they didn't interfere with each other. It's also unlikely you end up with a self-referential computed using a macro without using autofix since it results in application errors almost immediately. Running this on a large app turned out to be problematic since now I'm chasing down self-referentials. Trying to decide whether to patch this rule to convert them better or if I submit a new rule. |
I actually think the new rule If we make any changes to |
Given the following (admittedly incorrect) computed usage
This rule will convert it to the following, which blows up since the self-referential nature becomes more evident when an alias is installed under the hood.
A better conversion would be
storeIds: null
The text was updated successfully, but these errors were encountered: