Skip to content
This repository has been archived by the owner on Jan 30, 2023. It is now read-only.

Generate documentation site #358

Open
10 tasks
alexlafroscia opened this issue Jun 19, 2018 · 4 comments
Open
10 tasks

Generate documentation site #358

alexlafroscia opened this issue Jun 19, 2018 · 4 comments
Labels
enhancement Good for New Contributors Issue is scoped such that it can be handled by a new contributor, with the help of maintainers

Comments

@alexlafroscia
Copy link
Collaborator

alexlafroscia commented Jun 19, 2018

It would be great to generate a documentation site, maybe something using ember-cli-addon-docs! If we can publish it to the gh-pages branch here, then it'll be hosted at ember-cli.com/ember-ajax automatically, which would be pretty cool.

Some things to cover:

  • Usage
    • as a service
    • as an object
    • with the functions provided
  • TypeScript
    • Asserting response type by providing a type annotation
  • Error detection using the provided helpers
  • Common customization behavior

Other tasks

  • Simplify README (move some of the complex examples to the docs site)
@alexlafroscia alexlafroscia added enhancement Good for New Contributors Issue is scoped such that it can be handled by a new contributor, with the help of maintainers labels Jun 19, 2018
@sandstrom
Copy link
Contributor

I thought the aim was to move away from this addon, onto ember-fetch? If that's the case, wouldn't it make more sense to focus efforts elsewhere?

But perhaps I'm just mistaken about that 😄

@alexlafroscia
Copy link
Collaborator Author

With ember-cli-addon-docs it's pretty easy to create documentation, and I've never been happy with what this addon has. You're right, though, so maybe this will just stay open for a while.

I'm probably not going to do this myself, but if someone is new to OSS and wanted something that was pretty easy, I would be happy to work with them on re-vamping the documentation story here!

@sandstrom
Copy link
Contributor

sandstrom commented Jun 20, 2018

@alexlafroscia Somewhat related: how about a note on top of the readme, mentioning that ember-fetch also exist and is an equally good option. That way, beginners will at least be aware of that option. What do you think about that?

@alexlafroscia
Copy link
Collaborator Author

Yes, that's a great idea.

I'd also like to lobby (maybe through an RFC) that ember-ajax is removed as the default install on new projects and that ember-fetch, if anything, is installed instead.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Good for New Contributors Issue is scoped such that it can be handled by a new contributor, with the help of maintainers
Projects
None yet
Development

No branches or pull requests

2 participants