Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ember Twiddle is broken with v4 #1160

Closed
jelhan opened this issue Jul 29, 2020 · 4 comments
Closed

Ember Twiddle is broken with v4 #1160

jelhan opened this issue Jul 29, 2020 · 4 comments
Labels

Comments

@jelhan
Copy link
Contributor

jelhan commented Jul 29, 2020

Ember Twiddle is broken with v4.0.0-rc.3. It reports this build time error:

Addon ember-bootstrap encountered a build error:
- Installing addon package

- Installing addon package
Installing packages... This might take a couple of minutes.
- Installing addon package
- npm: Installing [email protected] ...
npm: Installed [email protected]
installing ember-bootstrap
Installing for Bootstrap 4 using preprocessor none
  install package bootstrap

Installing packages... This might take a couple of minutes.
- npm: Installing bootstrap@^4.3.1 ...
npm: Installed bootstrap@^4.3.1
Configuration file could not be edited. Manually update your ember-cli-build.js to include 'ember-bootstrap': {"bootstrapVersion":4,"importBootstrapCSS":true}
Installed addon package.
- Building
[Embroider:MacrosConfig] cannot read userConfigs until MacrosConfig has been finalized.


Stack Trace and Error Report: /tmp/error.dump.9a8bc518e0f255bd52f1c952d428aa7c.log

No addon.js created

It sounds like the embroider macros are causing that build error.

I tested with rc0, rc1 and rc2 as well. Seeing the same error for all of them. Which is not a big supprise as embroider macros were shipped in the first release candidate already.

@simonihmig
Copy link
Contributor

Maybe this should also be reported on https://github.com/ember-cli/ember-twiddle, as this seems to be more related to how embroider/macros and ember-twiddle interact, rather than ember-bootstrap itself?

@jelhan
Copy link
Contributor Author

jelhan commented Aug 3, 2020

Yeah. Also thought about that one. But haven't had the time yet to debug and report upstream. Created this ticket to avoid others thinking that they are doing something wrong.

@jelhan
Copy link
Contributor Author

jelhan commented Aug 21, 2020

Finally found the time to report it at Ember Twiddle: ember-cli/ember-twiddle#732

@jelhan jelhan added the bug label Sep 4, 2020
@jelhan
Copy link
Contributor Author

jelhan commented Nov 6, 2023

Ember Twiddle does not seem to be maintained anymore.

@jelhan jelhan closed this as completed Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants