Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript generic elements do not work and cause spin #5

Open
aaronjensen opened this issue Dec 29, 2018 · 1 comment
Open

typescript generic elements do not work and cause spin #5

aaronjensen opened this issue Dec 29, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@aaronjensen
Copy link
Contributor

I'm sorry for the flurry of issues... it's only because I like this package.

This one is somewhat esoteric as well, so if you don't intend to support typescript, I totally understand if you'd want to close this.

Start with this:

const x = () => (
  <Foo>
    test
  </Foo>
)

Update top <Foo> to <Foo<Bar>>

That will change the bottom </Foo> to </Bar>:

const x = () => (
  <Foo<Bar>>
    test
  </Bar>
)

Then put your point before the B in </Bar> and C-d, that will hang Emacs until you spam C-g.

The auto-rename-tag-mode will not work anymore until you disable it and reenable it.

@jcs090218
Copy link
Member

Thanks for your contribution to this package. Any reasonable issues are welcome, I will definitely like to make this package as much compatible to any circumstances as possible. Hence, I will look into this issue as soon as I have time! :D

@jcs090218 jcs090218 self-assigned this May 25, 2019
@jcs090218 jcs090218 added the bug Something isn't working label May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants