Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container name missing suffix for lsp--client-uri->path-fn #29

Open
minikN opened this issue Oct 30, 2020 · 2 comments
Open

container name missing suffix for lsp--client-uri->path-fn #29

minikN opened this issue Oct 30, 2020 · 2 comments

Comments

@minikN
Copy link

minikN commented Oct 30, 2020

Describe the bug
After starting a language server (intelephense in my case) and executing lsp-ui-peek-find-workspace-symbol I get this error:

Tramp-Buffer:

Error: No such container: lsp-langserver

Messages:

Tramp: Opening connection for lsp-langserver using docker...
Tramp: Sending command ‘exec docker  exec -it  lsp-langserver sh’
Tramp: Waiting for prompts from remote shell...
Tramp failed to connect.  If this happens repeatedly, try
    ‘M-x tramp-cleanup-this-connection’
Tramp: Waiting for prompts from remote shell...failed
Tramp: Opening connection for lsp-langserver using docker...failed
Cleaning up the recentf list...done (0 removed)
tramp-signal-hook-function: Tramp failed to connect.  If this happens repeatedly, try
    ‘M-x tramp-cleanup-this-connection’

According to @yyoncho in Gitter:

lsp--client-uri->path-fn is set to the client wihtout the ID
at some point we should copy the client and pass the proper lsp--client-uri->path-fn

To Reproduce

  • Open a project and wait for language server to start
  • Execute lsp-ui-peek-find-workspace-symbol

Expected behavior
The function should open a tramp connection to the docker container with the proper name

Which Language Server did you use
intelephense

OS

031 ~ ➜ uname -a
Linux voidwalker 5.8.16_1 emacs-lsp/lsp-mode#1 SMP Sat Oct 17 12:21:35 UTC 2020 x86_64 GNU/Linux
@minikN minikN changed the title Docker container missing suffix for lsp--client-uri->path-fn Docker container missing suffix for lsp--client-uri->path-fn Oct 30, 2020
@minikN minikN changed the title Docker container missing suffix for lsp--client-uri->path-fn container name missing suffix for lsp--client-uri->path-fn Oct 30, 2020
@yyoncho yyoncho transferred this issue from emacs-lsp/lsp-mode Oct 30, 2020
@zflat
Copy link
Contributor

zflat commented May 28, 2021

@yyoncho Can you please see my fix in #40 ? Do you have any input?

@yyoncho
Copy link
Member

yyoncho commented May 28, 2021

Sorry, I saw it then I forgot about it - will review it tomorrow my time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants