Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1972 Resolve Error message during validations in Common Properties #1973

Merged
merged 3 commits into from
May 23, 2024
Merged

#1972 Resolve Error message during validations in Common Properties #1973

merged 3 commits into from
May 23, 2024

Conversation

srikant-ch5
Copy link
Contributor

Fixes: #1972

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@srikant-ch5
elyra-ai#1972 Error Message is appearing even after valid condition i…
0de2fc8 
…n Common Properties Input validation.

Signed-off-by: srikant <[email protected]>
@srikant-ch5 srikant-ch5 self-assigned this May 21, 2024
matthoward366
matthoward366 reviewed May 21, 2024
View reviewed changes
canvas_modules/common-canvas/src/common-properties/ui-conditions/conditions-utils.js
@@ -723,7 +723,7 @@ function _validateInput(propertyId, controller, control, showErrors) {
if (isError) {
errorSet = true;
}
} else if (!isError && !errorSet) {
} else if ((!isError && !errorSet) || (!isError && errorSet)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

errorSet would never be true since the only place it's set to true is in the if part of this block. I'm not sure how this would work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @matthoward366 It is working in below case

evaluate.mov

So in the first iteration of for (const validation of validations) errorSet is set as true in above condition and in next iteration we are checking if it is true

matthoward366
matthoward366 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@matthoward366 matthoward366 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@matthoward366 matthoward366 merged commit 486bbfa into elyra-ai:main May 23, 2024
3 checks passed
mikieyx pushed a commit to mikieyx/canvas that referenced this pull request Jun 6, 2024
@srikant-ch5 @matthoward366
elyra-ai#1972 Resolve Error message during validations in Common Prop…
02027bc 
…erties (elyra-ai#1973)

Signed-off-by: srikant <[email protected]>
Co-authored-by: Matt Howard <[email protected]>
Signed-off-by: Michael Pavlik <[email protected]>
@srikant-ch5 srikant-ch5 deleted the 15618_SDG branch June 7, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthoward366 matthoward366 matthoward366 approved these changes

Assignees

@srikant-ch5 srikant-ch5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error Message is appearing even after valid condition in Common Properties Input validation.
2 participants
@srikant-ch5 @matthoward366