Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nft_build not using correct hash for /public/nft/ URLs #40

Open
elv-sam opened this issue Apr 27, 2022 · 1 comment
Open

nft_build not using correct hash for /public/nft/ URLs #40

elv-sam opened this issue Apr 27, 2022 · 1 comment
Assignees

Comments

@elv-sam
Copy link
Contributor

elv-sam commented Apr 27, 2022

I have identified and reproduced an issue on demov3 where the elv-live nft_build command does not use the hash containing the latest media for the URLs in /public/nft/ . That is to say, if the video content of the NFT is changed and nft_build is run, the old video content will still be present on newly minted NFTs.

I believe Serban and I actually encountered this on prod as well when setting up the initial tests for WWE, where the new DRM-free videos did not "take" until we saved in frowser (with no changes) then ran nft_build again. Until fixed, this is something to keep in mind when changing the video for the NFT "transformation".

My reproduction is iq__vBduFnK9XZ75S5uKETmz7ffgyad on demov3 bcl, which has a new video "Daily Dweebs" on the latest version but an old video "TEST" when minted.

@elv-sam
Copy link
Contributor Author

elv-sam commented Apr 28, 2022

Per Serban:
The URLs (embed, externa, image) are made by the fabric browser app. So you have to open the app and save (even without changes) for the URLs to be reconstructed.

Then call nft_build

So nft_build simply copies the URLs from asset_metadata into the nft area
We need to make this better but I was waiting for a good time to do it in collaboration with Kevin and introduce and NFT Build button in the fabric browser which would do all it needs to do to update

We are thinking of adding both "Add Contract" and "NFT Build" as fabric browser operations. Basically do the same thing the command line tool does

And maybe also fix the command line tool to recreate the URLs (in addition to what it does now). Or at least warn if the URLs are old - something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants