-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fn
type bound in Server.register
might be slightly off
#139
Comments
Hi, @SamWilsn, are there any issues you came across in production that's touching on this code? |
Here's an example: I have to disable the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The type bound for
fn
inregister
has avoid
return type:rpc-websockets/src/lib/server.ts
Line 147 in 46b0190
I'm rather new to TypeScript, but I would suggest a return type of
unknown | Promise<unknown>
to hint that the function isawait
'd later on:rpc-websockets/src/lib/server.ts
Lines 697 to 698 in 46b0190
The text was updated successfully, but these errors were encountered: