Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dialog remains on screen #2844

Open
shuuji3 opened this issue Apr 22, 2024 · 2 comments
Open

Publish dialog remains on screen #2844

shuuji3 opened this issue Apr 22, 2024 · 2 comments
Labels
c: bug Something isn't working

Comments

@shuuji3
Copy link
Member

shuuji3 commented Apr 22, 2024

The publish dialog should be closed when clicking the "Publish" button but now remains on the screen. This change might be caused by some changes related to the thread publishing feature but I'm not sure.

Screenshot from 2024-04-22 18-21-42
(After clicking "Publish" button. The new post is actually published and the editor text is cleared but the dialog isn't closed)

You can see the past behavior in the past version: https://deploy-preview-2001--elk-zone.netlify.app/

@shuuji3 shuuji3 added c: bug Something isn't working s: pending triage Pending Triage labels Apr 22, 2024
Copy link

stackblitz bot commented Apr 22, 2024

Solve in StackBlitz Codeflow Start a new pull request in StackBlitz Codeflow.

@shuuji3 shuuji3 removed the s: pending triage Pending Triage label Apr 22, 2024
@shuuji3
Copy link
Member Author

shuuji3 commented Apr 25, 2024

The close process was handled by this @published handler (https://github.com/elk-zone/elk/blob/main/components/modal/ModalContainer.vue#L70-L74) but it was implemented only on PublishWidget component, not PublishWidgetList.

So probably we might be able to fix this issue by adding a handler to PublishWidgetList component too or adding closing statement somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant