Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion to use find_package() over pkg_search_module() for better logs #2187

Open
danfe opened this issue Apr 29, 2024 · 0 comments
Open

Comments

@danfe
Copy link

danfe commented Apr 29, 2024

Currently, in the CMakeLists.txt, most components are detected with find_package() except LibArchive and PCRE, for which pkg_search_module() is used. Both seem to work, but find_package() yields better detection output, with library path and version, if available, as shown in the excerpt from the build logs diff below:

 -- INCSRCH plugin enabled
 -- INSIDE plugin enabled
 -- MULTIARC plugin enabled
+-- Found LibArchive: /usr/local/lib/libarchive.so (found version "3.7.2") 
+-- Found PCRE: /usr/local/lib/libpcre.so  
 -- Using LibArchive for limited RAR archives support.
 -- NETROCKS plugin enabled
 -- Found OpenSSL: /usr/lib/libcrypto.so (found version "1.1.1w")  
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant