Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color issue in new version of Terminal #682

Open
Soljanka opened this issue Aug 21, 2022 · 8 comments · May be fixed by #684
Open

Color issue in new version of Terminal #682

Soljanka opened this issue Aug 21, 2022 · 8 comments · May be fixed by #684
Labels
Needs Design Waiting for input from the UX team

Comments

@Soljanka
Copy link

Soljanka commented Aug 21, 2022

What Happened?

As @Romchec reported on reddit there is a minor color issue with the new default colors using htop and other cli apps. Especially the default color for Gray is a problem. Doesn't look like gray (debatable, at least for me) at all and makes gray text almost unreadable.

old terminal colors using htop
old

new default terminal colors
new

Steps to Reproduce

  1. Open terminal
  2. run htop

Expected Behavior

Default color for 'Gray' should be the first or second option from the default gray palette (or something similar)
Bildschirmfoto von 2022-08-21 16 05 50

OS Version

6.x (Odin)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

@jeremypw jeremypw added the Needs Design Waiting for input from the UX team label Aug 21, 2022
@jeremypw
Copy link
Collaborator

@danrabbit The default grey does look too dark to me as well - what would be the best color?

@wout
Copy link
Sponsor

wout commented Sep 3, 2022

I would like to add that with light themes, the new colour palette doesn't work well. For example, the colour White is very light on light backgrounds.

For example, here's the output from one of my Haskell apps:

image

And this is ESBuild:

image

With the solarised colour scheme, it's even more problematic I think:

image

@Antolius
Copy link
Member

We could invert white and bright white with black and bright black when switching from dark to light theme, like it's suggested in the ANK-dev/solarized-terminal-fixed project.

I'm not sure how bulletproof something like his would be, but I put together a small demo branch in case anyone wants to check it out. I don't have any Haskell apps that I could test with, but this is what htop looks like:

htop-high-contrast
htop-solarized-dark
htop-solarized-light

@Antolius Antolius linked a pull request Sep 12, 2022 that will close this issue
@queeup
Copy link
Contributor

queeup commented Sep 24, 2022

Old values were fine. It happens after this PR: #672

@jeremypw
Copy link
Collaborator

Maybe we should offer a choice of a select few named 3rd party palettes as well? I agree the default color palette has a lot of muddy greyish light colors in the light style (light green, light yellow, light blue, light cyan)

Screenshot from 2022-09-24 19 15 02

Not sure where this palette came from but I would have thought a minimum contrast between colors should be applied as we have no control over which colors an app will use together.

@Zyten
Copy link
Sponsor

Zyten commented Mar 31, 2023

Would it be acceptable to publish a temporary solution for this by making it such that clicking the Custom palette icon allows you to customise the currently active palette instead of defaulting to what I believe is the solarized palette?

i.e. If I were using the elementary dark palette, I can click on the Custom palette icon and just change the offending colour; which is much more convenient than trying to recreate the dark palette from scratch using the UI.

@wout
Copy link
Sponsor

wout commented May 2, 2023

This is still an issue in both the dark and light palettes. The problem seems to be that the same text colour palette is used in both like and dark themes. So light colours will blend with light backgrounds and vice versa.

@m93a
Copy link

m93a commented Jan 21, 2024

I used these commands to walkaround the issue for dark mode:

gsettings set io.elementary.terminal.settings palette '#073642:#dc322f:#859900:#b58900:#268bd2:#d33682:#2aa198:#eee8d5:#5e5c64:#dc322f:#586e75:#657b83:#839496:#6c71c4:#93a1a1:#fdf6e3'
gsettings set io.elementary.terminal.settings background '#2e2e2e'
gsettings set io.elementary.terminal.settings theme 'custom'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Waiting for input from the UX team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants