Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open relevant tab when clicking on a task finished notification #73

Open
elementaryBot opened this issue Apr 26, 2017 · 5 comments · May be fixed by #638
Open

Open relevant tab when clicking on a task finished notification #73

elementaryBot opened this issue Apr 26, 2017 · 5 comments · May be fixed by #638
Assignees
@igordsm
Labels
Status: Confirmed Verified by someone other than the reporter

Comments

@elementaryBot
Copy link
Contributor

elementaryBot commented Apr 26, 2017 •
edited by danirabbit

I had two tabs open, with a process running in tab two. When it finished, I received a notification (sweet!) but clicking the tab showed me Terminal with the first tab active, not the second one (not so sweet).

Ideally, whichever tab emitted the notification should be the active tab if a notification is clicked upon.

Launchpad Details: #LP1642970 Ruppal Singh - 2016-11-18 14:08:49 +0000

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@raphacosta27 raphacosta27 mentioned this issue Mar 2, 2020
Closed
@igordsm igordsm self-assigned this Oct 28, 2021
@igordsm
Copy link
Sponsor Contributor

igordsm commented Oct 28, 2021

I'm working on this. I have a working prototype and will send a PR later when I finish cleaning the code.

@jeremypw
Copy link
Collaborator

@igordsm You can always open a draft PR while your working on it for better visibilty 😄

@igordsm igordsm linked a pull request Nov 7, 2021 that will close this issue
Open
@janxkoci
Copy link

janxkoci commented Feb 8, 2024

I think this used to work, not long ago (maybe OS6?), but nowadays clicking the notification will instead do one of these two actions:

  • focus leftmost tab with Home directory open, or
  • create and focus a new tab with Home directory, if it didn't exist.

This is even if my command was actually running in different tab in different directory. Clicking the notification always goes Home.

@jeremypw jeremypw added the Status: Confirmed Verified by someone other than the reporter label Feb 8, 2024
@jeremypw
Copy link
Collaborator

jeremypw commented Feb 8, 2024

Worth looking at this again now some systemic issues with the notification handling are fixed.

@janxkoci
Copy link

janxkoci commented Feb 8, 2024

focus leftmost tab with Home directory open

I realized my wording had some untested assumption, so I tested it and it still holds - the above statement is even true if I open two tabs with Home directory and run e.g. sleep 10 in the second one. Clicking the notification will focus the leftmost Home tab no matter if the other Home tab running the command was focused or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igordsm igordsm

Labels
Status: Confirmed Verified by someone other than the reporter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Focus current tab igordsm/terminal
4 participants
@igordsm @jeremypw @janxkoci @elementaryBot