Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use binaries option to sign additional binaries #1723

Open
3 tasks done
voldemortensen opened this issue May 13, 2024 · 1 comment
Open
3 tasks done

Unable to use binaries option to sign additional binaries #1723

voldemortensen opened this issue May 13, 2024 · 1 comment
Labels

Comments

@voldemortensen
Copy link

Preflight Checklist

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details

  • Electron Packager Version:
    • Not relevant
  • Electron Version:
    • Not relevant
  • Operating System:
    • Not relevant
  • Last Known Working Electron Packager version::
    • Not relevant

Expected Behavior

I should be able to use binaries in osxSign to sign additional binaries.

Actual Behavior

The TypeScript definition explicitly removes the binaries key using Omit which results in this error:

forge.config.ts:15:7 - error TS2322: Type '{ binaries: string[]; optionsForFile: () => { entitlements: string; }; }' is not assignable to type 'true | OsxSignOptions'.
  Object literal may only specify known properties, and 'binaries' does not exist in type 'OsxSignOptions'.

To Reproduce

const config: ForgeConfig = {
  ...
  packagerConfig: {
    osxSign: {
      binaries: ["./path/to/extra/binary"],
    },
  },
};

Additional Information

binaries has been omitted since the OsxSignOptions type was introduced in a2a3ae5

Copy link

welcome bot commented May 13, 2024

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant